Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reduce language feature 100% #291

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

pilgrim-brave
Copy link
Contributor

No description provided.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner June 22, 2022 18:44
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Jun 23, 2022

Desktop Verification (using Win 11 x64)

1.38.119 Chromium: 101.0.4951.67 (Release)

  • downloaded/installed 1.38.119 Chromium: 101.0.4951.67
  • launched the browser using --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser (ensure you use the above switch when restarting)
  • checked brave://version and ensured that DisableReduceLanguage:Default

Quick note: doesn't appear like we're doing any type of min_version checks so every install will be opted into DisableReduceLanguage:Default. However, only 1.39.111 or higher or affected. So ensured there's no issues with FP.

image

1.38.119 Chromium: 101.0.4951.67 (Release)

  • downloaded/installed 1.39.111 Chromium: 102.0.5005.61
  • launched the browser using --variations-server-url=https://variations.bravesoftware.com/seed
  • loaded https://www.ghacks.net and noticed the broken fonts on the page
  • restarted the browser (ensure you use the above switch when restarting)
  • checked brave://version and ensured that DisableReduceLanguage:Default
  • loaded https://www.ghacks.net and ensured that the fonts appeared as expected
Example Example Example Example
image image image image

1.40.105 Chromium: 103.0.5060.53 (Release)

  • downloaded/installed 1.40.105 Chromium: 103.0.5060.53
  • launched the browser using --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser (ensure you use the above switch when restarting)
  • checked brave://version and ensured that DisableReduceLanguage:Default

image

Android Verification (using Pixel 6 running Android 13)

1.39.111 Chromium: 102.0.5005.61 (Release)

Using the STR/Cases from brave/brave-core#10408 (comment), ensured that Android was using https://variations.bravesoftware.com/seed as per the following:

image

Example Example
Screenshot_20220622-222141 Screenshot_20220622-222346

1.40.106 Chromium: 103.0.5060.53 (Release)

Using the STR/Cases from brave/brave-core#10408 (comment), ensured that Android was using https://variations.bravesoftware.com/seed as per the following:

image

Example Example
Screenshot_20220622-223303 Screenshot_20220622-223318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants