This repository has been archived by the owner on May 13, 2024. It is now read-only.
styled-components fixes #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utilized DefaultTheme
petemill
force-pushed
the
styled-components-fixes
branch
from
839520d
to
afc1ee6
Compare
|
Ci passed except audit-deps which is known |
petemill
added a commit
to brave/brave-core
that referenced
this pull request
Mar 10, 2021
zenparsing
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
storybook / tsc inside brave-ui wasn't complaining about these issues, nor was brave-core complaining when brave-ui was included via
npm link brave-ui. But brave-core is complaining when used as regular npm -> github dependency. So, here we are...