Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Make dark theme more useful #542

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Make dark theme more useful #542

merged 1 commit into from
Nov 21, 2019

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Sep 20, 2019

Changes

This adds some generic color overrides that should be useful for most browser components in dark mode: text, panel colors, and button colors.

I've tweaked the Card component to use the panelBackground theme color since it's also required to be able to theme the webcompat reporter dialog.

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 🎨

@petemill petemill merged commit 7485c3c into master Nov 21, 2019
@petemill petemill deleted the expand-dark-theme branch November 21, 2019 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants