Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix dropdown colors for Shields in Windows #463

Merged
merged 3 commits into from
May 6, 2019
Merged

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented May 6, 2019

Test Plan:

Ensure dropdowns on Shields have visible text across platforms

Now link: https://brave-ui-e45cj4qm1.now.sh

Intended to address brave/brave-browser#4213

@cezaraugusto cezaraugusto requested a review from petemill May 6, 2019 22:16
@@ -185,7 +185,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
<div
className="c3"
>
MISSING: monthApr
MISSING: monthMay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤦‍♀

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment needs to be clearer or the next person won't know why 'DO NOT MODIFY' is there. More detail in comment...

src/features/shields/select/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cezaraugusto cezaraugusto merged commit e0aff04 into master May 6, 2019
cezaraugusto added a commit that referenced this pull request May 7, 2019
Fix dropdown colors for Shields in Windows
cezaraugusto added a commit that referenced this pull request May 7, 2019
Fix dropdown colors for Shields in Windows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants