Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

create a component to better handle tabular data #1

Closed
cezaraugusto opened this issue Nov 1, 2017 · 7 comments
Closed

create a component to better handle tabular data #1

cezaraugusto opened this issue Nov 1, 2017 · 7 comments

Comments

@cezaraugusto
Copy link
Contributor

follow-up of brave/browser-laptop#9032. We need this to unblock brave/browser-laptop#11177 and fix brave/browser-laptop#11551. This component should be prioritized over others.

Component should:

  • make use of css grid
  • support large amounts of data (such as cookies, browser history, etc)
@cezaraugusto cezaraugusto self-assigned this Nov 1, 2017
@cezaraugusto
Copy link
Contributor Author

btw long term this should replace browser-laptop SortableTable component

@petemill
Copy link
Member

petemill commented Nov 1, 2017

not sure what advantage we get from using css grid for a table, but I'd suggest React Virtualized for a popular component that can handle thousands of items and render only what's visible. It has a lot of different types of components, helpers and very easily styled. You can use it for lists not just tables, and so put your own completely custom components in.

@cezaraugusto
Copy link
Contributor Author

reason for grid is to make use of position: sticky mainly, could be made by other means btw like flexbox or any other positioning of choice just want to avoid table.

ya React Virtualized is the strongest option by now.

@petemill
Copy link
Member

petemill commented Nov 3, 2017 via email

@cezaraugusto
Copy link
Contributor Author

after you mentioned I got really into this and found https://bugs.chromium.org/p/chromium/issues/detail?id=702927 so that's possible as you said: https://jsfiddle.net/cezaraugusto/ww6237cL/

which is confusing, iirc it's per spec not supposed to work https://drafts.csswg.org/css-position/#position-property and https://drafts.csswg.org/css-position/#valdef-position-sticky. For me it's still hacky but well we can use table thanks Google 🙂

@petemill
Copy link
Member

petemill commented Nov 3, 2017 via email

@cezaraugusto
Copy link
Contributor Author

we have it now so closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants