This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #8228: Use specific Scene resign functions when dealing with UI only #8247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Do not ever use applicationWillResignActive for SCENE specific stuff.
applicationWillResignActive is called for EVERY SCENE, but sceneWillResignActive is called only for the one scene that will resignActive.
To fix the issue, we must only update UI for the one scene inside of the scene specific delegate. If updating UI for all scenes (or doing logic that applies to all windows), then we can do it inside applicationWillResignActive.
This pull request fixes #8228
Submitter Checklist:
NSLocalizableString()
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement