Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8228: Use specific Scene resign functions when dealing with UI only #8247

Closed
wants to merge 1 commit into from

Conversation

Brandon-T
Copy link
Collaborator

Summary of Changes

  • Do not ever use applicationWillResignActive for SCENE specific stuff.

  • applicationWillResignActive is called for EVERY SCENE, but sceneWillResignActive is called only for the one scene that will resignActive.

  • To fix the issue, we must only update UI for the one scene inside of the scene specific delegate. If updating UI for all scenes (or doing logic that applies to all windows), then we can do it inside applicationWillResignActive.

This pull request fixes #8228

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

applicationWillResignActive is called for EVERY SCENE, but sceneWillResignActive is called only for the one scene that will resignActive.
@Brandon-T Brandon-T added this to the 1.58 milestone Oct 13, 2023
@Brandon-T Brandon-T self-assigned this Oct 13, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner October 13, 2023 17:54
@Brandon-T Brandon-T closed this Oct 13, 2023
@Brandon-T Brandon-T deleted the bugfix/SceneResignation branch October 13, 2023 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #6577] Content in the Private window is shown when switching the apps
2 participants