Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Use the brave-core debounce service #8165

Closed
wants to merge 4 commits into from
Closed

Use the brave-core debounce service #8165

wants to merge 4 commits into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Sep 27, 2023 •
edited
Loading

Summary of Changes

This pull request fixes brave/brave-browser#36033

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

See issue

Screenshots:

Simulator Screenshot - iPhone 14 - 2024-02-07 at 11 23 01

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba force-pushed the brave-core-1.60.x branch 3 times, most recently from f7ce448 to ea85101 Compare October 18, 2023 22:11
Base automatically changed from brave-core-1.60.x to development October 20, 2023 19:21
@cuba cuba marked this pull request as ready for review February 7, 2024 18:15
@cuba cuba requested a review from a team as a code owner February 7, 2024 18:15
@cuba
Copy link
Contributor Author

cuba commented Feb 13, 2024

Moved to brave-core: brave/brave-core#22039

@cuba cuba closed this Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the debounce service from brave-core and drop the iOS custom service
1 participant
@cuba