Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Remove old CoreData migration logic. #7185

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Apr 1, 2023

Summary of Changes

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added the QA/No label Apr 1, 2023
@iccub iccub added this to the 1.50 milestone Apr 1, 2023
@iccub iccub requested a review from a team as a code owner April 1, 2023 09:41
@iccub iccub merged commit 836814b into development Apr 3, 2023
@iccub iccub deleted the nobug/cd_migration_cleanup branch April 3, 2023 15:02
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants