Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add missing isMetaMask and isBraveWallet definitions on `window.e… #6060

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

This pull request fixes #6059

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open safari debugger
  2. Check that both isMetaMask and isBraveWallet are now defined as true

Screenshots:

Screen Shot 2022-09-26 at 1 44 48 PM

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.44 milestone Sep 26, 2022
@StephenHeaps StephenHeaps requested review from kylehickinson, nuo-xu and a team September 26, 2022 17:45
@StephenHeaps StephenHeaps self-assigned this Sep 26, 2022
@StephenHeaps StephenHeaps merged commit 6681f13 into development Sep 26, 2022
@StephenHeaps StephenHeaps deleted the wallet-ethereum-isBraveWallet branch September 26, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isMetaMask, isBraveWallet property for Ethereum property
2 participants