Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Regional adblock option showing for English locale #959

Closed
iccub opened this issue Mar 9, 2019 · 1 comment
Closed

Regional adblock option showing for English locale #959

iccub opened this issue Mar 9, 2019 · 1 comment
Assignees
@iccub
Labels
bug QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.9

Comments

@iccub
Copy link
Contributor

iccub commented Mar 9, 2019

No description provided.

@iccub iccub self-assigned this Mar 9, 2019
@iccub iccub changed the title Regional adblock option shown for English locale Regional adblock option showing for English locale Mar 9, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Mar 11, 2019
@iccub
Fix brave#959, don't show regional adblock option for english locale.
5e8e88a
iccub added a commit to iccub/brave-ios that referenced this issue Mar 11, 2019
@iccub
Fix brave#959, don't show regional adblock option for english locale.
dc64339
iccub added a commit to iccub/brave-ios that referenced this issue Mar 11, 2019
@iccub
Fix brave#959, don't show regional adblock option for english locale.
a5ee84b
iccub added a commit to iccub/brave-ios that referenced this issue Mar 11, 2019
@iccub
Fix brave#959, don't show regional adblock option for english locale.
29540b8
iccub added a commit to iccub/brave-ios that referenced this issue Mar 12, 2019
@iccub
Fix brave#959, don't show regional adblock option for english locale.
1058d9f
@srirambv srirambv added this to the 1.9 milestone Mar 26, 2019
This was referenced Mar 26, 2019
Closed
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Mar 26, 2019 •
edited by kjozwiak
Loading

  • Verification passed on iPhone 7+ running 1.9(19.3.25.21)

    • Verified no regional adblock shown in settings for English locale
    • Verified regional adblock option shows up and enabled by default when a different locale is set

  • Verified passed with 1.9 (19.03.25.21) on iPad 5th Gen using test plan from Fix #959, don't show regional adblock option for english locale. #961

  • Verified no regional adblock shown for English language:

IMG_EBF9D1B2B672-1

  • Verified regional adblock shown for another (French) language:

IMG_A9FB823E97F8-1

  • Verification passed on iPhone 8 running 1.9(19.3.25.21)
    • Verified no regional adblock shown in settings for English locale

English - No regional ad block

  • Verified regional adblock option shows up and enabled by default when a different locale is set

Spanish - Regional Adblock

  • Verification passed on iPhone 6 running 1.9(19.3.25.21)

    • Verified no regional adblock shown in settings for English locale
    • Verified regional adblock option shows up and enabled by default when a different locale is set

  • Verification PASSED with 1.9 (19.3.27.19) on iPad Mini 4 using the above STR.

    • Verified no regional adblock shown in settings for English locale
    • Verified regional adblock option shows up and enabled by default when a different locale is set

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
6 participants
@kjozwiak @iccub @srirambv @LaurenWags @btlechowski @GeetaSarvadnya