Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ensure sync code words/qr code doesn't get stuck while generating #942

Closed
srirambv opened this issue Mar 6, 2019 · 1 comment
Closed

Ensure sync code words/qr code doesn't get stuck while generating #942

srirambv opened this issue Mar 6, 2019 · 1 comment
Labels
blocked: needs investigation bug QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.9

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 6, 2019

Description:

Some times sync code words/qr code may take time to generate causing the sync screen to be blank

Steps to Reproduce

  1. Enable sync
  2. Create a new sync chain
  3. Code word/QR code sometime doesn't show up

Actual result:
file

Expected result:
Should always generate code words/qr code

Reproduces how often: [Easily reproduced, Intermittent Issue]
Intermittent. Ran into this only twice but cant consistently reproduce

Brave Version:
1.9(19.3.2.15)

Device details:
iPhone 7+ (iOS 12.1)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.9 milestone Mar 6, 2019
iccub added a commit that referenced this issue Mar 15, 2019
@iccub
Fix #974: add ability to call browserified script
93d7bb5 
Fix #942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 15, 2019
@iccub
Fix brave#974: add ability to call browserified script
115431d 
Fix brave#942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 15, 2019
@iccub
Fix brave#974: add ability to call browserified script
019e422 
Fix brave#942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 15, 2019
@iccub
Fix brave#974: add ability to call browserified script
f6c9001 
Fix brave#942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit that referenced this issue Mar 18, 2019
@iccub
Fix #974: add ability to call browserified script
7db2e2e 
Fix #942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit that referenced this issue Mar 18, 2019
@iccub
Fix #974: add ability to call browserified script
98e2a09 
Fix #942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 25, 2019
@iccub
Fix brave#974: add ability to call browserified script
1c5228c 
Fix brave#942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit that referenced this issue Mar 25, 2019
@iccub
Fix #974: add ability to call browserified script
627d7d7 
Fix #942: generate qr code/codewords synchronously,
leave sync group if it fails.
iccub added a commit that referenced this issue Mar 25, 2019
@iccub
Fix #974: add ability to call browserified script
42e9307 
Fix #942: generate qr code/codewords synchronously,
leave sync group if it fails.
@jhreis jhreis closed this as completed in 5652d60 Mar 25, 2019
jhreis pushed a commit that referenced this issue Mar 25, 2019
Merge pull request #975 from brave/bugfix/942
8a65a2f 
Fix #974, fix #942 : add ability to call browserified script, fix qr code/codewords bug
This was referenced Mar 26, 2019
Closed
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 26, 2019 •
edited by btlechowski
Loading

  • Verified passed with 1.9 (19.03.25.21) on iPad 5th Gen using STR from description.
  • Verification passed on iPhone 6/7 and iPad pro running 1.9(19.3.25.21)
  • Verification PASSED with 1.9 (19.03.25.21) on iPad Mini 4 using the above STR.
  • Verification passed on iPhone 8 running 1.9(19.3.25.21)
  • Verification passed on iPhone SE running 1.9(19.3.25.21)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked: needs investigation bug QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
5 participants
@kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya