Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Learn more on the Brave Rewards panel overlaps other text #8243

Closed
hffvld opened this issue Oct 12, 2023 · 2 comments
Closed

Learn more on the Brave Rewards panel overlaps other text #8243

hffvld opened this issue Oct 12, 2023 · 2 comments

Comments

@hffvld
Copy link
Collaborator

hffvld commented Oct 12, 2023

Description:

Learn more on the Brave Rewards panel overlaps other text.

Steps to Reproduce

  1. Launch Brave
  2. Enable Rewards by tapping BR icon in the URL search bar or by going to the settings
  3. Open any unsupported website, for example https://amazon.com
  4. Tap BR icon > Observe. Sometimes you need to reopen BR panel multiple times (~2 - 10 times) to see the issue.

Actual result:

Learn more for unsupported websites on the Brave Rewards panel overlaps other text. This is happening on iPad in both Landscape and Portrait mode, but I wasn't able to reproduce it on iPhone.

1 2
1 2

Expected result:

Learn more must not overlap other text on BR panel.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.58 (23.10.12.20)
BraveCore: 1.58.139 (117.0.5938.153)

  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? YES

Device details:

Device/OS: iPad Air [iPadOS 16.5.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@kylehickinson
Copy link
Collaborator

Probably fixed by 533cebf (1.60.x)

@hffvld hffvld changed the title Lear more on the Brave Rewards panel overlaps other text Learn more on the Brave Rewards panel overlaps other text Oct 17, 2023
@iccub iccub added this to the 1.60 milestone Oct 25, 2023
@iccub iccub closed this as completed Oct 25, 2023
@iccub iccub modified the milestones: [old] 1.60, 1.60 Nov 4, 2023
@hffvld
Copy link
Collaborator Author

hffvld commented Nov 6, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.1]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.60 (23.11.4.14)
BraveCore: 1.60.105 (119.0.6045.59)

STEPS:

  1. Followed the steps from Learn more on the Brave Rewards panel overlaps other text #8243 (comment)

ACTUAL RESULTS:

  • Verified that Learn More is not overlapping with other strings
  • Verified the same on iPad and iPhone

iPad iPhone
1 2
1 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants