Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix NTP-SI P3A total count metric name #8092

Closed
DJAndries opened this issue Sep 19, 2023 · 1 comment · Fixed by #8094
Closed

Fix NTP-SI P3A total count metric name #8092

DJAndries opened this issue Sep 19, 2023 · 1 comment · Fixed by #8094
Assignees
@kylehickinson
Labels
bug Epic: P3A QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.58

Comments

@DJAndries
Copy link

The NTP-SI P3A total count metric name is incorrect. On iOS, it's currently creativeInstanceId.count.total. In order to correspond with reports from other platforms, the name should be changed to creativeInstanceId.total.count.
@kylehickinson kylehickinson self-assigned this Sep 19, 2023
@kylehickinson kylehickinson added this to the 1.58 milestone Sep 19, 2023
kylehickinson added a commit that referenced this issue Sep 19, 2023
@kylehickinson
Fix #8092: Use correct histogram name for NTP-SI P3A total count answer
fa31d55
@kylehickinson kylehickinson mentioned this issue Sep 19, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Sep 20, 2023
@kylehickinson
Fix #8092: Use correct histogram name for NTP-SI P3A total count answ…
2d88456 
…er (#8094)
iccub pushed a commit that referenced this issue Sep 20, 2023
@kylehickinson @iccub
Fix #8092: Use correct histogram name for NTP-SI P3A total count answ…
24b1b11 
…er (#8094)
@Uni-verse Uni-verse mentioned this issue Oct 3, 2023
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 3, 2023 •
edited
Loading

Verified on iPhone X running IOS 16.7 using version 1.58 (23.9.26.21)

Preconditions:

  1. Will need the iOS debug menu so dev channel build is required
  2. Enabled the following BraveCore Switches and corresponding values (see image)
    • Dont Randomize Upload Interval
    • Upload Interval = 60 (seconds)
    • Typical Rotation Interval = 60 (seconds)
    • Express Rotation interval = 60 (seconds)
  3. App restart may be required
  4. User will have to cycle through NTP SI campaign for the creativeinstanceid to show up.
preconditions
  • Ensured metric name is creativeInstanceId.total.count in histogram logs
  • Ensured creativeinstanceid is incremented each time user views NTP SI

logged - #8178

IMG_3549

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#8092: Use correct histogram name for NTP-SI P3A t…
0721696 
…otal count answer (brave/brave-ios#8094)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: P3A QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.58
Development

Successfully merging a pull request may close this issue.

Fix #8092: Use correct histogram name for NTP-SI P3A total count answer brave/brave-ios
3 participants
@kylehickinson @DJAndries @Uni-verse