-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync folder structure not kept #982
Conversation
27b7c05
to
064711d
Compare
064711d
to
454d445
Compare
Pushed a commit with fixes for this review notices, 454d445 . Will squash this commit after approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remove the observer hack and manually call set_visible(false) for both our permanent nodes. See the comments
89ea1e1
to
537fef7
Compare
537fef7
to
2d9e9f3
Compare
2d9e9f3
to
5313db5
Compare
Sync folder structure not kept
@AlexeyBarabash uplift request to |
Sync folder structure not kept
Things done in PR:
Pending Bookmarks
folder and moved into actual parent folder once it arrived;Pending Bookmarks
andDeleted Bookmarks
folder is hidden byBraveBookmarkPermanentNode
Fixes brave/brave-browser#2133
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Manual is described in brave/brave-browser#2133 .
Auto tests:
npm run test -- brave_unit_tests --filter=BraveBookmarkChangeProcessorTest.ItemAheadOfFolder:BraveBookmarkChangeProcessorTest.ItemAheadOfFolderAgressive:BraveBookmarkChangeProcessorTest.ItemAheadOfFolderRequireStrictSorting
Reviewer Checklist: