Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Gmail" language in SafeBrowsing text #9311

Closed
wants to merge 2 commits into from
Closed

Removed "Gmail" language in SafeBrowsing text #9311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c499631
gmail services message removed
soham4abc Jul 2, 2021
3f5e04b
Merge branch 'brave:master' into master
soham4abc Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/resources/generated_resources_en-GB.xtb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<translation id="1123753900084781868">Live Caption is not available at the moment</translation>
<translation id="1124772482545689468">User</translation>
<translation id="1125550662859510761">Looks like <ph name="WIDTH"/> x <ph name="HEIGHT"/> (Native)</translation>
<translation id="1295971429974142731">Does not protect you against dangerous websites, downloads and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Gmail and Search.</translation>
<translation id="1295971429974142731">Does not protect you against dangerous websites, downloads and extensions. Where available, you’ll still get safe browsing protection in other Brave services.</translation>
<translation id="7264603236241251563">To set up an Android phone to be used as a security key with this computer for the first time, open Brave on your phone and go to Settings &gt; Passwords &gt; Use phone as a security key. Then tap 'Connect new device' and scan this QR code.</translation>
<translation id="1128109161498068552">Do not allow any sites to use system exclusive messages to access MIDI devices</translation>
<translation id="1128591060186966949">Edit search engine</translation>
Expand Down
2 changes: 1 addition & 1 deletion app/settings_strings.grdp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,7 +1553,7 @@
No protection (not recommended)
</message>
<message name="IDS_SETTINGS_SAFEBROWSING_NONE_DESC" desc="Description for safe browsing no protection mode">
Does not protect you against dangerous websites, downloads, and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Gmail and Search.
Does not protect you against dangerous websites, downloads, and extensions. Where available, you’ll still get safe browsing protection in other Brave services.
</message>
<message name="IDS_SETTINGS_SAFEBROWSING_DISABLE_DIALOG_TITLE" desc="Title for the confirmation dialog to turn off SafeBrowsing">
Turn off Safe Browsing?
Expand Down
2 changes: 1 addition & 1 deletion browser/ui/android/strings/android_chrome_strings.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,7 @@ Your Brave account may have other forms of browsing history like searches and ac
No protection (not recommended)
</message>
<message name="IDS_SAFE_BROWSING_NO_PROTECTION_SUMMARY" desc="Summary for Safe Browsing no protection mode.">
Does not protect you against dangerous websites, downloads, and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Gmail and Search.
Does not protect you against dangerous websites, downloads, and extensions. Where available, you’ll still get safe browsing protection in other Brave services.
</message>

<!-- Safe Browsing enhanced protection preferences -->
Expand Down
2 changes: 1 addition & 1 deletion browser/ui/android/strings/translations/android_chrome_strings_en-GB.xtb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<translation id="1113597929977215864">Show simplified view</translation>
<translation id="1118561384561215815">Get help with tasks on the web</translation>
<translation id="8577410793886633063">How you interact with Brave, settings that you’ve selected, details of Brave crashes</translation>
<translation id="1295971429974142731">Does not protect you against dangerous websites, downloads and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Gmail and Search.</translation>
<translation id="1295971429974142731">Does not protect you against dangerous websites, downloads and extensions. Where available, you’ll still get safe browsing protection in other Brave services.</translation>
<translation id="1129510026454351943">Details: <ph name="ERROR_DESCRIPTION"/></translation>
<translation id="1141800923049248244">{FILE_COUNT,plural, =1{1 download pending.}other{# downloads pending.}}</translation>
<translation id="1142732900304639782">Don’t offer to translate these sites</translation>
Expand Down