Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdf not loading by PDFJS after basic auth #784

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Nov 1, 2018

Fix brave/brave-browser#1788

Fix chromium upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=805476
webRequest.onBeforeSendHeaders, webRequest.onSendHeaders, and webRequest.onHeadersReceived should be dispatched as the life cycle specified in https://developer.chrome.com/extensions/webRequest.

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

See brave/brave-browser#1788 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Nov 1, 2018
@yrliou yrliou requested review from bbondy and bridiver November 1, 2018 22:37
@yrliou yrliou merged commit d6444a4 into master Nov 2, 2018
yrliou added a commit that referenced this pull request Nov 2, 2018
Fix pdf not loading by PDFJS after basic auth
@yrliou
Copy link
Member Author

yrliou commented Nov 2, 2018

master: d6444a4
0.58.x: 4722ed5

@yrliou yrliou deleted the fix_pdfjs_basic_auth branch November 2, 2018 19:00
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFs fail to load if behind basic auth
3 participants