Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sponsored image P3A instrumentation for New Tab Page (uplift to 1.17.x) #7063

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 5, 2020

Uplift of #6924
Resolves brave/brave-browser#12267

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.17.x - Beta milestone Nov 5, 2020
@bsclifton bsclifton requested a review from a team November 5, 2020 05:50
@bsclifton bsclifton requested a review from iefremov as a code owner November 5, 2020 05:50
@bsclifton bsclifton self-assigned this Nov 5, 2020
@bsclifton
Copy link
Member Author

Tested on Nightly - put a detailed test plan in brave/brave-browser#12267

@kjozwiak
Copy link
Member

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-linux/2/execution/node/249/log. However, this is a known intermittent issue and will be fixed via brave/brave-browser#12351. Doesn't block uplift.

02:37:30  1 test failed:
02:37:30      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:527)

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-windows/3/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-windows/2/execution/node/85/log/.

Add sponsored image P3A instrumentation for New Tab Page
@bbondy bbondy force-pushed the bsc-ntp-p3a-1.17.x branch from 9ab6f77 to 86c799d Compare November 10, 2020 19:09
@kjozwiak
Copy link
Member

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-windows/5/ as we ran into Agent was removed as per https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-windows/4/execution/node/189/log/.

16:20:04  Cannot contact i-00b3575ae47a19053-windows-swarm-dec75eeb: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException
16:25:04  Could not connect to i-00b3575ae47a19053-windows-swarm-dec75eeb to send interrupt signal to process

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-macos/4/ as test-unit and test-browser failed as per https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-macos/3/execution/node/234/log/ and https://ci.brave.com/job/pr-brave-browser-bsc-ntp-p3a-1.17.x-macos/3/execution/node/247/log/.

18:11:41  FAILED: obj/media/base/test_support/fake_demuxer_stream.o 

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6924 (comment).

@kjozwiak kjozwiak merged commit 4452b54 into 1.17.x Nov 11, 2020
@kjozwiak kjozwiak deleted the bsc-ntp-p3a-1.17.x branch November 11, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants