Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide qr code (uplift to 1.17.x) #7033

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Hide qr code (uplift to 1.17.x) #7033

merged 1 commit into from
Nov 3, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 3, 2020 •
edited by kjozwiak
Loading

Uplift of #7020
Resolves brave/brave-browser#12475

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.17.x - Beta milestone Nov 3, 2020
@bsclifton bsclifton requested a review from a team November 3, 2020 05:14
@bsclifton bsclifton requested a review from a team as a code owner November 3, 2020 05:14
@bsclifton bsclifton self-assigned this Nov 3, 2020
@bsclifton bsclifton requested review from emerick and NejcZdovc and removed request for a team November 3, 2020 05:14
kjozwiak
kjozwiak approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers. Because this is a simple TypeScript change, it won't be picked up by Jenkins. However, Travis passed without any issues.

@kjozwiak kjozwiak merged commit 311edbd into 1.17.x Nov 3, 2020
@kjozwiak kjozwiak deleted the bsc-1.17.x-qr-code branch November 3, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
feature/rewards
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @kjozwiak @NejcZdovc