Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for desktop mode #6984

Merged
merged 1 commit into from
Oct 29, 2020
Merged

[Android] Fix for desktop mode #6984

merged 1 commit into from
Oct 29, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Oct 29, 2020

Resolves brave/brave-browser#12382
Resolves brave/brave-browser#11928

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 29, 2020
@samartnik samartnik added this to the 1.18.x - Nightly milestone Oct 29, 2020
@samartnik samartnik self-assigned this Oct 29, 2020
@samartnik samartnik force-pushed the android_desktop_mode branch from 7ca4286 to cc01c74 Compare October 29, 2020 19:31
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit d77d058 into master Oct 29, 2020
@samartnik samartnik deleted the android_desktop_mode branch October 29, 2020 20:40
brave-builds pushed a commit that referenced this pull request Oct 29, 2020
brave-builds pushed a commit that referenced this pull request Oct 29, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Oct 30, 2020

Verification PASSED on Samsung S10+ running Android 10 using 1.18.21 CR: 87.0.4280.27

  • ensured that selecting Desktop site via Settings correctly displayed the check mark (selected)
  • ensured that every page within that tab (Desktop Mode) is correctly loading desktop version of websites
  • ensured disabling Desktop Mode starts using the mobile version of websites again
  • ensured that Desktop Mode persists when closing/re-opening Brave
  • ensured that Desktop Mode doesn't persists to other created tabs if already enabled
  • ensured that you can have multiple tabs opened using Desktop Mode

Verification passed on Samsung Tab A with Android 10 running 1.18.21 x64 nightly build

  • Verified Desktop mode is not enabled by default
  • Verified visiting a mobile page and selecting desktop site from menu loads the page in desktop mode
  • Verified enabling desktop mode from site settings auto enables and checks desktop mode in menu for each new tab
  • Verified desktop mode is retained between relaunches
  • Verified visiting a desktop page and reloading doesn't switch back to mobile page

Verification PASSED on Samsung Galaxy J3 version 5.1.1 running Bravearm 1.18.21 CR: 87.0.4280.27

  • ensured that selecting Desktop site via Settings correctly displayed the check mark (selected)
  • ensured that every page within that tab (Desktop Mode) is correctly loading desktop version of websites
  • ensured disabling Desktop Mode starts using the mobile version of websites again
  • ensured that Desktop Mode persists when closing/re-opening Brave
  • ensured that Desktop Mode doesn't persists to other created tabs if already enabled
  • ensured that you can have multiple tabs opened using Desktop Mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop mode toggle is broken Desktop mode can't be disabled on nightly
3 participants