Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures both bitcoin.com dropdowns aren't open at the same time #6754

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 2, 2020

Fixes brave/brave-browser#11959

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 2, 2020
@ryanml ryanml requested review from petemill and emerick October 2, 2020 05:23
@ryanml ryanml self-assigned this Oct 2, 2020
@ryanml ryanml changed the title Ensures both bitcooin.com dropdowns aren't open at the same time Ensures both bitcoin.com dropdowns aren't open at the same time Oct 2, 2020
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more complicated than just having a click handler for the document (anywhere outside respective dropdown area) to close that dropdown? But it will work!

@ryanml ryanml merged commit efd1e6f into master Oct 2, 2020
@ryanml ryanml deleted the fix-11959 branch October 2, 2020 07:38
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryanml added a commit that referenced this pull request Oct 3, 2020
Ensures both bitcoin.com dropdowns aren't open at the same time
ryanml added a commit that referenced this pull request Oct 3, 2020
Ensures both bitcoin.com dropdowns aren't open at the same time
@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2020

Verification passed on

Brave 1.17.11 Chromium: 86.0.4240.68 (Official Build) nightly (x86_64)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Linux / Windows 10 OS Version 1809 (Build 17763.1457) / macOS Version 10.15.7 (Build 19H2)
  • Verified both dropdowns don't remain open on the widget when selected
Linux Windows macOS
linuxdropdown windowsdropdown macosdropdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Widget] Dropdown should collapse on click
4 participants