Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies certain Safety Check and Safe Browsing strings. #6699

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Sep 24, 2020

Fixes brave/brave-browser#11345

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.16.x - Nightly milestone Sep 24, 2020
@mkarolin mkarolin requested review from petemill and bbondy September 24, 2020 22:01
@mkarolin mkarolin requested a review from bridiver as a code owner September 24, 2020 22:01
@mkarolin mkarolin self-assigned this Sep 24, 2020
@mkarolin mkarolin merged commit 31e4dbe into master Sep 30, 2020
@mkarolin mkarolin deleted the maxk-fix-safe-browsing-text branch September 30, 2020 19:08
mkarolin added a commit that referenced this pull request Oct 1, 2020
Modifies certain Safety Check and Safe Browsing strings.
mkarolin added a commit that referenced this pull request Oct 1, 2020
Modifies certain Safety Check and Safe Browsing strings.
@kjozwiak
Copy link
Member

kjozwiak commented Oct 2, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.17.7 Chromium: 86.0.4240.55 (Official Build) nightly (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.15.6 (Build 19G73)
Old Text Updated Text
Screen Shot 2020-10-02 at 12 45 01 AM Screen Shot 2020-10-02 at 12 47 13 AM
Screen Shot 2020-10-02 at 12 44 38 AM Screen Shot 2020-10-02 at 12 48 32 AM
Screen Shot 2020-10-02 at 12 44 53 AM Screen Shot 2020-10-02 at 12 48 44 AM

@rebron
Copy link
Collaborator

rebron commented Oct 2, 2020

@kjozwiak Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] update Safe Browsing text in brave://settings
5 participants