Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL preconditions #6625

Merged
merged 2 commits into from
Sep 11, 2020
Merged

GL preconditions #6625

merged 2 commits into from
Sep 11, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 11, 2020

Resolves brave/brave-browser#11664
Resolves brave/brave-browser#11670

Submitter Checklist:

Test Plan:

defined in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@pilgrim-brave pilgrim-brave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please update the GL docs at https://github.com/brave/brave-site-specific-scripts/#preconditions-key to list the new preconditions

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 599337e into master Sep 11, 2020
@NejcZdovc NejcZdovc deleted the gl-ac branch September 11, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds AC feature flag to Greaselion Greaselion doesn't respect twitter-tips-enabled precondition
4 participants