Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using PKCE flow for Gemini Authentication, adding shared oauth utility (1.13) #6325

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Using PKCE flow for Gemini Authentication, adding shared oauth utility (1.13) #6325

merged 1 commit into from
Aug 16, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 3, 2020 •
edited by kjozwiak
Loading

Uplift of #6306
Resolves brave/brave-browser#11043

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml added this to the 1.13.x - Beta milestone Aug 3, 2020
@ryanml ryanml requested a review from a team August 3, 2020 22:05
@ryanml ryanml self-assigned this Aug 3, 2020
@ryanml ryanml force-pushed the 1.13-g-pkce branch 2 times, most recently from 6a28931 to 3b09188 Compare August 14, 2020 20:56
@ryanml
Merge pull request #6306 from brave/gemini-pkce
dd66ba6 
Using PKCE flow for Gemini Authentication, adding shared oauth utility
@kjozwiak
Copy link
Member

Restarting macOS via https://ci.brave.com/job/brave-core-build-pr-macos/job/PR-6325/5/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-1.13-g-pkce-macos/2/execution/node/174/log/.

16:49:57  FAILED: obj/brave/components/brave_ads/browser/browser/ads_service_impl.o

kjozwiak
kjozwiak approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6306 (comment).

@kjozwiak kjozwiak merged commit 287dec5 into 1.13.x Aug 16, 2020
@kjozwiak kjozwiak deleted the 1.13-g-pkce branch August 16, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
feature/crypto-widgets
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak