[1.11.x] Do not immediately expire sync v1 infobar about v2

[petemill]

We were relying on the base implementation. Possibly i don't understand how that works because I had assumed that it would only expire the infobar after a change of site, not a New Tab or resurrecting a tab on browser restart. But in release (and frustratingly not on local builds) that's not the case - the infobar was immediately dismissing. So, change the logic to an info bar which does not automatically expire for the active tab.

Resolves brave/brave-browser#10621

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[bsclifton]

LGTM++

[kjozwiak]

Looks like audit-deps failed on each platform due to lodash which is a known issue and fixed in 1.13.x and 1.12.x and doesn't block uplift.

test-browser failed on Win x64 as per

22:07:41  1 test crashed:
22:07:41      BraveToolbarViewTest.AvatarButtonIsShownMultipleProfiles (../../brave/browser/ui/views/toolbar/brave_toolbar_view_browsertest.cc:93)

Believe this is an intermittent issue but I'll let @petemill or @bsclifton comment. I don't believe this is blocking.

Going to restart macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-1.11.x-fix-sync-v1-infobar-expire/1/execution/node/358/log/ due to the following:

20:26:27  FAILED: obj/content/browser/browser/browser_main_loop.o 

[kjozwiak]

test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-1.11.x-fix-sync-v1-infobar-expire/2/execution/node/409/log/ which is a known issue and doesn't block uplift.

[kjozwiak]

Uplift/revert approved after deliberating with @brave/uplift-approvers. Both @jsecretan and @rebron are aware this is being reverted and will be added in the next 1.11.x HF.