-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve promotions from db when fetched recently #5760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Jun 6, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 6, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc
Outdated
Show resolved
Hide resolved
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 6, 2020 23:44
cc7bb55
to
6c74432
Compare
NejcZdovc
approved these changes
Jun 7, 2020
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 7, 2020 21:37
6c74432
to
774a5b1
Compare
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 8, 2020 12:33
774a5b1
to
7ee9849
Compare
zenparsing
approved these changes
Jun 8, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc
Outdated
Show resolved
Hide resolved
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 8, 2020 14:46
7ee9849
to
8e7b4d4
Compare
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 8, 2020 17:16
8e7b4d4
to
44ea744
Compare
emerick
force-pushed
the
rewards-fetch-promotions-from-cache
branch
from
June 8, 2020 17:17
44ea744
to
f38c5ed
Compare
zenparsing
approved these changes
Jun 8, 2020
zenparsing
approved these changes
Jun 8, 2020
Rerunning CI for Android. |
emerick
added
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
labels
Jun 8, 2020
Android completed successfully. |
emerick
removed
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
labels
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9513
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.