Fixed proper theme color is not used #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
changed the title
simonhong
changed the title
simonhong
changed the title
simonhong
force-pushed
the
brave_theme_c83
branch
from
8295bab to
c999336
Compare
Active tab's bg color was not properly picked. Also, respected user's custom theme. Brave theme color will not be used for native browser UI when custom theme is used. Other web UI(settings page or shields panel) will apply brave theme mode regardless of custom theme.
simonhong
force-pushed
the
brave_theme_c83
branch
from
c999336 to
72a2a04
Compare
simonhong
added
CI/skip-android
mkarolin
approved these changes
May 28, 2020
bsclifton
approved these changes
May 28, 2020
32 tasks
mkarolin
pushed a commit
that referenced
this pull request
Jun 4, 2020
Fixed proper theme color is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active tab's bg color was not properly picked.
Also, respected user's custom theme.
Brave theme color will not be used for native browser UI when custom theme is used.
Other web UI(settings page or shields panel) will apply brave theme mode regardless of custom theme.
Resolves brave/brave-browser#9957
Resolves brave/brave-browser#9808
Light:
Dark:
Custom:
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.