Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci pipeline sync 1.9.x #5673

Merged
merged 1 commit into from
May 27, 2020
Merged

ci pipeline sync 1.9.x #5673

merged 1 commit into from
May 27, 2020

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented May 27, 2020

Uplift of #5668

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mihaiplesa mihaiplesa self-assigned this May 27, 2020
@mihaiplesa mihaiplesa requested a review from a team May 27, 2020 14:40
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihaiplesa uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and milestones are correct.

@mihaiplesa mihaiplesa merged commit ad11ce6 into 1.9.x May 27, 2020
@mihaiplesa mihaiplesa deleted the mplesa-ci-pipeline-sync-1.9.x branch May 27, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants