Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield panel design dp #5618

Merged
merged 15 commits into from
May 25, 2020
Merged

Shield panel design dp #5618

merged 15 commits into from
May 25, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#9888

Submitter Checklist:

Test Plan:

Follow the UI spec from brave/brave-browser#6831

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 22, 2020
@deeppandya deeppandya self-assigned this May 22, 2020
@deeppandya deeppandya force-pushed the shield_panel_design_dp branch from 56bc0ae to 941f137 Compare May 24, 2020 00:15
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 3330220 into master May 25, 2020
@deeppandya deeppandya deleted the shield_panel_design_dp branch May 25, 2020 16:25
@bsclifton bsclifton added this to the 1.11.x - Nightly milestone May 25, 2020
@bsclifton
Copy link
Member

Added missing milestone to this PR and brave/brave-browser#9888 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Implement simpler Shield Panel
3 participants