-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import/export db for QA. Issue #9766. #5560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gdregalo could we add notes to this actions, so that QA knowns where export will go and in which folder and what should be the name when importing? Also could be that when you click import you are just prompt to select a file instead of fixed path? |
@NejcZdovc |
@gdregalo qa has a lot of test data and if they can select file they can have files names per versions for example so no renaming is needed. |
4ff8755
to
5449d97
Compare
mImportRewardsDb = findPreference(QA_IMPORT_REWARDS_DB); | ||
mExportRewardsDb = findPreference(QA_EXPORT_REWARDS_DB); | ||
setRewardsDbClickListeners(); | ||
checkQACode(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved here for proper ACTION_GET_CONTENT
handling. When it is onStart
it request code additionaly, when file is chosen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Follow up PR for import is created here #5688 |
Verification passed on OnePlus 6T with Android 10 running 1.11.28 Nightly build
|
Resolves: brave/brave-browser#9766
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.