Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referrer test cases in preparation for overhaul #5545

Merged
merged 5 commits into from
May 22, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented May 14, 2020

This adds tests that will be useful in brave/brave-browser#8696.

Submitter Checklist:

Test Plan:

npm test -- brave_browser_tests --filter='BraveContentSettingsAgentImplBrowserTest.*Referrer*'

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested a review from iefremov May 14, 2020 01:13
@fmarier fmarier self-assigned this May 14, 2020
fmarier added 3 commits May 13, 2020 19:06
None of the current hooks we have need to tamper with page using
the internal `chrome://` pages, and only brave_webtorrent needs
the extension scheme.
@fmarier fmarier force-pushed the francois-add-referrer-tests-7933 branch from 7d2d4e4 to 534f3e6 Compare May 14, 2020 02:06
@fmarier fmarier added this to the 1.11.x - Nightly milestone May 22, 2020
@fmarier
Copy link
Member Author

fmarier commented May 22, 2020

The CI build passed: https://ci.brave.com/job/pr-brave-browser-francois-add-referrer-tests-7933/8/

It's not reflected on GitHub because I ran the upstream job (brave-browser) instead of the downstream job (brave-core).

@fmarier fmarier merged commit 858cd58 into master May 22, 2020
@fmarier fmarier deleted the francois-add-referrer-tests-7933 branch May 22, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants