Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent crash in Confirmations due to invalid wallet - 1.8.x #5393

Merged
merged 1 commit into from
May 5, 2020
Merged

Intermittent crash in Confirmations due to invalid wallet - 1.8.x #5393

merged 1 commit into from
May 5, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 27, 2020 •
edited by kjozwiak
Loading

Uplift of #5357
Resolves brave/brave-browser#8535

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.8.x - Release milestone Apr 27, 2020
@tmancey tmancey requested a review from a team April 27, 2020 21:59
@tmancey tmancey requested a review from NejcZdovc as a code owner April 27, 2020 21:59
@tmancey tmancey self-assigned this Apr 27, 2020
@NejcZdovc NejcZdovc removed their request for review April 30, 2020 10:14
@tmancey tmancey force-pushed the issues/8535-1.8.x branch from e16330b to b0244a5 Compare May 4, 2020 22:01
@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2020

@tmancey mind taking a look? Looks like init is failing on every platform after rebasing.

@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2020

Looks like Travis failed TEST_SUITE=test-security due to the yargs-parser package which is a known issue and not blocking uplift.

kjozwiak
kjozwiak approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5357 (comment).

@kjozwiak kjozwiak merged commit f905f25 into 1.8.x May 5, 2020
@kjozwiak kjozwiak deleted the issues/8535-1.8.x branch May 5, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak