Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brave-extension with hash for extension which sets scope on … #532

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

bsclifton
Copy link
Member

…content settings calls

Contingent on brave/brave-extension#68 being reviewed/accepted/merged

If brave/brave-extension#68 is merged, this PR needs to have the vendor/brave-extension hash updated

This will fix brave/brave-browser#1198

@bsclifton
Copy link
Member Author

brave/brave-extension#68 was merged; ready for review

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsclifton bsclifton merged commit cacede9 into master Oct 1, 2018
@bsclifton bsclifton deleted the content-settings-add-scope branch October 1, 2018 19:28
bsclifton added a commit that referenced this pull request Oct 1, 2018
Update `brave-extension` with hash for extension which sets scope on …
bsclifton added a commit that referenced this pull request Oct 1, 2018
Update `brave-extension` with hash for extension which sets scope on …
@bsclifton
Copy link
Member Author

master cacede9
0.56.x 8ab835f
0.55.x 48af7a9

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shields don't work after re-enabling in private browsing mode
3 participants