Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement farbling levels #5220

Merged
merged 5 commits into from
Apr 23, 2020
Merged

Implement farbling levels #5220

merged 5 commits into from
Apr 23, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 10, 2020

Resolves brave/brave-browser#9186

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner April 10, 2020 16:54
@pilgrim-brave pilgrim-brave marked this pull request as draft April 10, 2020 17:37
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farbling_levels branch from 6682c4d to 7d002e6 Compare April 13, 2020 22:19
@pilgrim-brave pilgrim-brave self-assigned this Apr 13, 2020
@pilgrim-brave pilgrim-brave marked this pull request as ready for review April 13, 2020 22:20
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farbling_levels branch from 7d002e6 to f7bbf88 Compare April 16, 2020 14:47
@bridiver bridiver force-pushed the mpilgrim_farbling_levels branch 2 times, most recently from 62d2e4a to e6a742c Compare April 20, 2020 17:18
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_farbling_levels branch from e6a742c to 7ee4abf Compare April 22, 2020 18:29
@bridiver bridiver force-pushed the mpilgrim_farbling_levels branch from 7ee4abf to 6fb7a4d Compare April 22, 2020 20:42
@bridiver bridiver force-pushed the mpilgrim_farbling_levels branch from 6fb7a4d to e13f545 Compare April 22, 2020 21:36
@bridiver bridiver added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 22, 2020
@bridiver
Copy link
Collaborator

windows CI is consistently failing to checkout see https://ci.brave.com/job/brave-browser-build-pr/job/mpilgrim_farbling_levels/13/execution/node/271/log/
I can't see any reason why there would be a windows-only issue so I'm going to merge anyway

@bridiver bridiver merged commit 1b8a065 into master Apr 23, 2020
@bridiver bridiver deleted the mpilgrim_farbling_levels branch April 23, 2020 00:43
@bridiver bridiver removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 23, 2020
@bridiver bridiver added this to the 1.10.x - Nightly milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: Canvas
3 participants