Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash while importing from welcome ui #5018

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 23, 2020

To trigger importing, importing types should be passed.
issue: brave/brave-browser#8808

Resolves brave/brave-browser#8808

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

To trigger importing, importing types should be passed.
issue: brave/brave-browser#8808
@simonhong simonhong added this to the 1.8.x - Nightly milestone Mar 23, 2020
@simonhong simonhong self-assigned this Mar 23, 2020
@simonhong simonhong mentioned this pull request Mar 23, 2020
32 tasks
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works great 😄👍

@bsclifton
Copy link
Member

Merging as I've manually verified and CI is good (was one test timeout, unrelated to this https://ci.brave.com/job/brave-browser-build-pr/job/fix_import_crash_from_welcome_ui/1/execution/node/405/log/)

@bsclifton bsclifton merged commit a88b0ec into master Mar 23, 2020
@bsclifton bsclifton deleted the fix_import_crash_from_welcome_ui branch March 23, 2020 23:46
@ryanml ryanml mentioned this pull request Mar 24, 2020
32 tasks
mkarolin pushed a commit that referenced this pull request Apr 8, 2020
Fixed crash while importing from welcome ui
bsclifton added a commit that referenced this pull request Apr 13, 2020
Fixed crash while importing from welcome ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check failure while importing from welcome page
2 participants