Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes inconsistent conversion dates in logs #4945

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fixes inconsistent conversion dates in logs #4945

merged 1 commit into from
Mar 16, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 13, 2020

Resolves brave/brave-browser#8689

Submitter Checklist:

Test Plan:

  • Ad conversions should trigger on average ~1 day unless passing the --brave-ads-debug command-line arg which will trigger on average ~5 minutes (and should reflect the epoch time in ad_conversions.json

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 1.8.x - Nightly milestone Mar 13, 2020
@tmancey tmancey self-assigned this Mar 13, 2020
@tmancey tmancey requested a review from moritzhaller March 14, 2020 00:14
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Mar 14, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Mar 14, 2020

Linux failed, restarting Linux

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@btlechowski
Copy link

btlechowski commented Mar 16, 2020

LGTM

Verification passed on

Brave 1.8.14 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}}
OS Ubuntu 18.04 LTS

Verified the min date for triggering the conversion is now respected

[2397:1:0316/175026.711449:INFO:ad_conversions.cc(179)] Started ad conversion timer for creative_instance_id bc6523ee-a790-487a-bb0e-7fda52b8af7e with creative set id 32439113-32d2-4b50-9497-405b7eedd1d5 which will trigger on 2020-03-17 23:20:51.000 UTC
[4738:1:0318/185811.441574:INFO:ad_conversions.cc(143)] Ad conversion for creative instance id bc6523ee-a790-487a-bb0e-7fda52b8af7e with creative set id 32439113-32d2-4b50-9497-405b7eedd1d5 triggered on 2020-03-17 23:20:51.000 UTC

Verified trigger date in ad_conversions.json is the same as in logs

Verified --brave-ads-debug shortens the process.

The log still does not show when conversion was triggered, it shows the min date that the conversion could trigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent conversion dates in logs
3 participants