Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation icon is visible after installing g-translate extension #4928

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 13, 2020

This regression comes from aa8c67
Originally, TranslateIconView::UpdateImpl() was not called if
extension is installed.

Resolves brave/brave-browser#8082

Submitter Checklist:

Test Plan:

Refer to STR in issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.8.x - Nightly milestone Mar 13, 2020
@simonhong simonhong requested review from yrliou and bsclifton March 13, 2020 02:47
@simonhong simonhong self-assigned this Mar 13, 2020
This regression comes from
aa8c67.
Originally, TranslateIconView::UpdateImpl() was not called if
extension is installed.
@simonhong simonhong force-pushed the issue_8082_tr_icon branch from 2170065 to 891945d Compare March 13, 2020 02:52
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong
Copy link
Member Author

simonhong commented Mar 13, 2020

Merged because lint, browser test failure in CI are all not related with this PR.

@simonhong simonhong merged commit 1588787 into master Mar 13, 2020
@simonhong simonhong deleted the issue_8082_tr_icon branch March 13, 2020 06:34
brave-builds pushed a commit that referenced this pull request Mar 13, 2020
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.8.9 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.15.3 (Build 19D76)
  • Verified the STR outlined under Appears broken translate button brave-browser#8082 (comment)
  • ensured that the Translate icon appears in the URL when visiting a website in another locale
  • ensured that the Translate icon displays a modal re: installing the translation extension
  • ensured once the Google Translate extension was installed, the Translate icon isn't displayed
  • ensured that the Translate button re-appears on websites using another locale once the extension has been removed

Screen Shot 2020-03-13 at 3 14 40 PM

Screen Shot 2020-03-13 at 3 11 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appears broken translate button
3 participants