Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Do not auto opt-in sponsored images after re-enabling backgrounds #4875

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

cezaraugusto
Copy link
Contributor

Fix brave/brave-browser#8552

Submitter Checklist:

Test Plan:

  1. Go to brave://newtab -> and select dashboard setting
  2. Toggle OFF both "Show Background Image" and "Show Sponsored Images"
  3. Toggle ON "Show Background Image".
  4. "Show Sponsored Images" should stay off.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserve "Show Sponsored Images" off setting when "Show Background Image" is toggled on
2 participants