Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Hide sync menu from app menu if it's disabled #4570

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 10, 2020

and fix failed app menu test.

fix brave/brave-browser#8160
fix brave/brave-browser#8158 (only for 1.3)

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.3.x - Release Hotfix 1 milestone Feb 10, 2020
@simonhong simonhong requested review from bbondy, darkdh and a team February 10, 2020 07:09
@simonhong simonhong self-assigned this Feb 10, 2020
@simonhong
Copy link
Member Author

Pushed different PR for fix this issue because brave app menu code was refactored from 1.4.
#4571 could be uplifted from 1.6 to 1.4 if needed.

@simonhong
Copy link
Member Author

Only network-audit and test-install were failed in CI. and it seems both are not related with this PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x after deliberating with @brave/uplift-approvers. As per #4570 (comment), looks like audit-network and test-install failed which are expected failures and not related to this specific PR.

Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 6039aac into 1.3.x Feb 12, 2020
@kjozwiak kjozwiak deleted the hide_sync_app_menu branch February 12, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants