Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore bookmark icon url when browser gets bookmark form sync cloud (uplift to 1.4.x) #4434

Closed
wants to merge 1 commit into from
Closed

Ignore bookmark icon url when browser gets bookmark form sync cloud (uplift to 1.4.x) #4434

wants to merge 1 commit into from

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jan 27, 2020 •
edited by bsclifton
Loading

Uplift of #4420

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash self-assigned this Jan 27, 2020
@AlexeyBarabash AlexeyBarabash added this to the 1.4.x - Dev milestone Jan 27, 2020
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv January 27, 2020 17:14
@kjozwiak
Copy link
Member

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4420_sync_and_bookmark_icons_fix_7893_1.4.x/1/execution/node/743/log/ failing.

Restarting Win x64 due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4420_sync_and_bookmark_icons_fix_7893_1.4.x/1/execution/node/585/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux Uplift/Blocked labels Jan 27, 2020
@kjozwiak
Copy link
Member

Added the PR/Blocked label till we get more information on brave/brave-browser#7948 that @btlechowski found on Nightly.

@bsclifton
Copy link
Member

Closing in favor of #4412

@bsclifton bsclifton closed this Jan 30, 2020
@bsclifton bsclifton deleted the pr4420_sync_and_bookmark_icons_fix_7893_1.4.x branch January 30, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS Uplift/Blocked
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyBarabash @kjozwiak @bsclifton