Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 7044: Do not import cookies from Chrome and Firefox. (uplift to 1.1.x) #4236

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Issue 7044: Do not import cookies from Chrome and Firefox. (uplift to 1.1.x) #4236

merged 1 commit into from
Dec 16, 2019

Conversation

bsclifton
Copy link
Member

Uplift of #4121
Fixes brave/brave-browser#7044

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #4121 from brave/ie_dont_import_cookies
acd7e2d 
Issue 7044: Do not import cookies from Chrome and Firefox.
@bsclifton bsclifton added this to the 1.1.x - Release Hotfix 2 milestone Dec 16, 2019
@bsclifton bsclifton requested a review from a team December 16, 2019 04:20
@bsclifton bsclifton self-assigned this Dec 16, 2019
@bsclifton bsclifton changed the title Issue 7044: Do not import cookies from Chrome and Firefox. (uplift to 1.2.x) Issue 7044: Do not import cookies from Chrome and Firefox. (uplift to 1.1.x) Dec 16, 2019
@bsclifton bsclifton removed the request for review from bridiver December 16, 2019 05:21
kjozwiak
kjozwiak approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.1.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that all the correct labels are being used and the associated issue(s) are moved into the correct milestone.

@kjozwiak kjozwiak merged commit 21a030d into 1.1.x Dec 16, 2019
@kjozwiak kjozwiak deleted the pr4121_ie_dont_import_cookies_1.1.x branch December 16, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.1.x - Release Hotfix 2
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak