Fixes brave://version Brave logo in dark mode. #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brave/brave-browser#7221 Copied product_logo.png to product_logo_white.png to be used in dark mode. Chromium change: https://chromium.googlesource.com/chromium/src/+/7ccedcb1069f7a3ae1a17f835bdfa148bdad326a commit 7ccedcb1069f7a3ae1a17f835bdfa148bdad326a Author: Robbie Gibson <rkgibson@google.com> Date: Thu Oct 10 10:20:24 2019 +0000 Add dark mode styling to chrome://version The uses the <picture> element to select different sources for the logo image based on the device's mode. It also moves the white logo files to the same place as the existing files for consistency. There are corresponding CLs to move the google_chrome logo files as well. Bug: 1006216
mkarolin
force-pushed
the
maxk-fix-version-logo
branch
from
27760e4 to
fa96922
Compare
|
CI looks good (had a failure on macOS install?) Pulling down the code now to verify fix 😄 |
bsclifton
approved these changes
Dec 6, 2019
brave-builds
pushed a commit
that referenced
this pull request
Dec 6, 2019
brave-builds
pushed a commit
that referenced
this pull request
Dec 6, 2019
brave-builds
pushed a commit
that referenced
this pull request
Dec 6, 2019
This was referenced Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7221
Copied product_logo.png to product_logo_white.png to be used in dark
mode.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.