Token check #4025
Merged
Token check #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
NejcZdovc
force-pushed
the
token-check
branch
3 times, most recently
from
132f84a
to
9a8c03f
Compare
NejcZdovc
requested review from
gdregalo,
kylehickinson and
tmancey
as code owners
NejcZdovc
force-pushed
the
token-check
branch
from
9a8c03f
to
383fd62
Compare
NejcZdovc
force-pushed
the
token-check
branch
2 times, most recently
from
2741d4b
to
c7c182d
Compare
masparrow
reviewed
Nov 27, 2019
components/brave_rewards/browser/rewards_notification_service_impl.cc
Outdated
Show resolved
Hide resolved
masparrow
approved these changes
Nov 27, 2019
NejcZdovc
force-pushed
the
token-check
branch
from
c7c182d
to
ed0c654
Compare
gdregalo
approved these changes
Nov 27, 2019
tmancey
reviewed
Nov 27, 2019
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/ledger_client_mock.cc
Outdated
Show resolved
Hide resolved
kylehickinson
approved these changes
Nov 27, 2019
NejcZdovc
commented
Nov 27, 2019
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
token-check
branch
2 times, most recently
from
41c7fa0
to
f44ae4a
Compare
tmancey
reviewed
Nov 28, 2019
|
|
||
| const uint64_t now = static_cast<uint64_t>(base::Time::Now().ToDoubleT()); | ||
|
|
||
| return token->expires_at > 0 && token->expires_at < now; |
There was a problem hiding this comment.
nit: now should be checked with <=
NejcZdovc
force-pushed
the
token-check
branch
from
f44ae4a
to
08a6e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7022
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
covered with tests
Reviewer Checklist:
After-merge Checklist:
changes has landed on.