Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to brave://credits (uplift to 0.73.x) #3953

Merged
merged 13 commits into from
Nov 10, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 9, 2019

Uplift of #3899

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2019

Restarting macOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/francois-add-missing-licenses-6809-0.73.x/1/execution/node/476/log/:

23:40:55  ERROR: Error cloning remote repo 'origin'
23:40:55  hudson.plugins.git.GitException: Could not init /Users/jenkins/jenkins/workspace/brave-browser-build-pr/francois-add-missing-licenses-6809-0.73.x
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:957)
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:737)
23:40:55  	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)
23:40:55  	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)
23:40:55  	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
23:40:55  	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
23:40:55  	at hudson.remoting.Request$2.run(Request.java:369)
23:40:55  	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
23:40:55  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
23:40:55  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
23:40:55  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
23:40:55  	at java.base/java.lang.Thread.run(Thread.java:834)
23:40:55  	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to mac-mini2-sf
23:40:55  		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
23:40:55  		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
23:40:55  		at hudson.remoting.Channel.call(Channel.java:955)
23:40:55  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
23:40:55  		at jdk.internal.reflect.GeneratedMethodAccessor1070.invoke(Unknown Source)
23:40:55  		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
23:40:55  		at java.base/java.lang.reflect.Method.invoke(Method.java:566)
23:40:55  		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
23:40:55  		at com.sun.proxy.$Proxy98.execute(Unknown Source)
23:40:55  		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)
23:40:55  		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)
23:40:55  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)
23:40:55  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)
23:40:55  		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)
23:40:55  		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
23:40:55  		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
23:40:55  		... 4 more
23:40:55  Caused by: hudson.plugins.git.GitException: Command "git init /Users/jenkins/jenkins/workspace/brave-browser-build-pr/francois-add-missing-licenses-6809-0.73.x" returned status code 128:
23:40:55  stdout: 
23:40:55  stderr: error: copy-fd: write returned: No space left on device
23:40:55  fatal: cannot copy '/Applications/Xcode.app/Contents/Developer/usr/share/git-core/templates/info/exclude' to '/Users/jenkins/jenkins/workspace/brave-browser-build-pr/francois-add-missing-licenses-6809-0.73.x/.git/info/exclude': No space left on device
23:40:55  
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2302)
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2298)
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1857)
23:40:55  	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:955)
23:40:55  	... 11 more

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 9, 2019
@kjozwiak
Copy link
Member

Restarting macOS again due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/francois-add-missing-licenses-6809-0.73.x/3/execution/node/323/log/:

14:01:16  Error: Command 'git ls-tree HEAD ios/third_party/motion_transitioning_objc/src' returned non-zero exit status 128 in /Users/jenkins/jenkins/workspace/add-missing-licenses-6809-0.73.x/src
14:01:16  error: object directory /Users/jenkins/cache/chromium.googlesource.com-chromium-src/objects does not exist; check .git/objects/info/alternates
14:01:16  fatal: not a tree object

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This was also uplifted into 0.71.x as per #3955 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed after several restarts.

@kjozwiak kjozwiak merged commit 47252a6 into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the francois-add-missing-licenses-6809-0.73.x branch November 10, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants