Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for unused keys in Transaction deserialization (uplift to 0.73.x) #3935

Merged

Conversation

brave-builds
Copy link
Collaborator

Uplift of #3917

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 8, 2019
@brave-builds brave-builds added this to the 0.73.x - Dev milestone Nov 8, 2019
@NejcZdovc NejcZdovc removed their request for review November 8, 2019 20:04
@kjozwiak
Copy link
Member

Restarting iOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3917_issue-6745-transactions-reset-after-restart_0.73.x/1/execution/node/543/log/:

18:57:01  1>WARNING: subprocess '"git" "fetch" "origin" "+refs/branch-heads/*:refs/branch-heads/*"' in /Users/jenkins/cache/chromium.googlesource.com-chromium-src failed; will retry after a short nap...
18:57:01  script returned exit code 143

Restarting macOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3917_issue-6745-transactions-reset-after-restart_0.73.x/1/execution/node/582/log/:

18:55:16  Syncing Gclient (with reset)
18:55:16  /Users/jenkins/jenkins/workspace/tions-reset-after-restart_0.73.x: gclient sync --force --nohooks --with_branch_heads --with_tags --upstream
18:55:30  WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
18:56:40  [0:01:00] Still working on:
18:56:40  [0:01:00]   src
18:56:40  [0:01:10] Still working on:
18:56:40  [0:01:10]   src
18:56:49  [0:01:20] Still working on:
18:56:49  [0:01:20]   src
18:57:00  Sending interrupt signal to process
18:57:01  [0:01:30] Still working on:
18:57:01  [0:01:30]   src
18:57:01  script returned exit code 143

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 10, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This fix was also uplifted into 0.71.x as per #3937 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed after restarting macOS several times.

@kjozwiak kjozwiak merged commit 1ab6a05 into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the pr3917_issue-6745-transactions-reset-after-restart_0.73.x branch November 10, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants