Adding state for unsupported ads regions to ntp rewards widget (0.73) #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding state for unsupported ads regions to ntp rewards widget
|
Looks like this one was aborted when we were just concentrating on getting the |
|
Restarting |
kjozwiak
added
CI/skip-android
kjozwiak
approved these changes
Nov 10, 2019
There was a problem hiding this comment.
Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This fix was also uplifted into 0.71.x as per #3902 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed after several restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#6759
Uplifts: #3876