Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left sig right sig match failure (uplift to 0.71.x) #3896

Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 6, 2019

Uplift of #3819
Fixes brave/brave-browser#6545

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 6, 2019
@brave-builds brave-builds added this to the 0.71.x - Release milestone Nov 6, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv November 6, 2019 20:26
@bsclifton
Copy link
Member

Manually replayed with https://ci.brave.com/job/brave-browser-build-pr/job/pr3819_issue-6545-left-sig-right-sig-match-failure_0.71.x/5/flowGraphTable/ to get past error that was happening w/ Android git cache...

@bsclifton
Copy link
Member

Verified problem was w/ Android git cache 👍 Cancelled build as it ran into an unrelated error in create_dist for Windows and queued up a proper re-run of CI 😄

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 7, 2019
@bsclifton
Copy link
Member

bsclifton commented Nov 7, 2019

Failed on macOS only w/ https://ci.brave.com/job/brave-browser-build-pr/job/pr3819_issue-6545-left-sig-right-sig-match-failure_0.71.x/6/execution/node/455/log/

05:15:53  /Users/jenkins/jenkins/workspace/g-right-sig-match-failure_0.71.x/src/brave/chromium_src/third_party/blink/renderer/modules/encryptedmedia/navigator_request_media_key_system_access.cc:18:10: fatal error: 'brave/components/brave_drm/brave_drm.mojom.h' file not found
05:15:53  #include "brave/components/brave_drm/brave_drm.mojom.h"
05:15:53           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
05:15:53  1 error generated.

Restarted with:
https://ci.brave.com/job/brave-core-build-pr/job/PR-3896/5/console

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI shows as red - but when you view, it's actually passing. There we two xUnit test result parse errors, but ALL tests passed properly. Good to go 👍

@bsclifton bsclifton merged commit 644bc42 into 0.71.x Nov 8, 2019
@bsclifton bsclifton deleted the pr3819_issue-6545-left-sig-right-sig-match-failure_0.71.x branch November 8, 2019 03:13
petemill pushed a commit that referenced this pull request Jul 27, 2020
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
petemill pushed a commit that referenced this pull request Jul 28, 2020
Reland C74 on master.

This reverts commit 25a0ea7, reversing
changes made to bd47a7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants