Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left sig right sig match failure (uplift to 0.73.x) #3894

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Left sig right sig match failure (uplift to 0.73.x) #3894

merged 1 commit into from
Nov 8, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 6, 2019 •
edited by bsclifton
Loading

Uplift of #3819
Fixes brave/brave-browser#6545

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 6, 2019
@brave-builds brave-builds added this to the 0.73.x - Dev milestone Nov 6, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, NejcZdovc, srirambv and rebron November 6, 2019 20:27
@mihaiplesa mihaiplesa force-pushed the pr3819_issue-6545-left-sig-right-sig-match-failure_0.73.x branch from 6ce4de9 to 111e683 Compare November 6, 2019 22:37
@mihaiplesa mihaiplesa force-pushed the pr3819_issue-6545-left-sig-right-sig-match-failure_0.73.x branch from 111e683 to 655344e Compare November 6, 2019 22:38
@bsclifton
Copy link
Member

Restarted CI - the brave-browser branch associated with this (gets auto-created) had an issue; version was missing from package.json. I remove the brave-browser branch and replayed CI for this PR. It re-generated the branch and it's running 👍

@bsclifton
Copy link
Member

Right after typing that up, I noticed CI failed:
https://ci.brave.com/job/brave-browser-build-pr/job/pr3819_issue-6545-left-sig-right-sig-match-failure_0.73.x/3/console

@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 8, 2019
@mihaiplesa
Copy link
Collaborator

Has passed for Android, Linux, Windows so applied skip labels and will need to be re-built only on iOS and macOS (unless no new changes pushed).

bsclifton
bsclifton approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 2bb6247 into 0.73.x Nov 8, 2019
@bsclifton bsclifton deleted the pr3819_issue-6545-left-sig-right-sig-match-failure_0.73.x branch November 8, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@mihaiplesa mihaiplesa Awaiting requested review from mihaiplesa

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @mihaiplesa @brave-browser-releases