Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating empty wallet message for unsupported regions #3849

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 31, 2019

Fixes brave/brave-browser#6604

Submitter Checklist:

Test Plan:

  1. Enable rewards
  2. Wait for initilization
  3. Close browser
  4. Open Preferences file and search for countryid_at_install
  5. Replace current value with 19024
  6. Restart Browser
  7. Navigate to brave://rewards
  8. Confirm the page wallet empty message conforms to the spec in the issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.73.x - Nightly milestone Oct 31, 2019
@ryanml ryanml requested a review from a team October 31, 2019 23:24
@ryanml ryanml self-assigned this Oct 31, 2019
@ryanml ryanml force-pushed the fix-6604 branch 2 times, most recently from eca907b to cc58244 Compare November 4, 2019 21:53
tmancey added a commit that referenced this pull request Nov 4, 2019
Fixes maximum daily ads at 21 instead of 20 (follow up to #3849)
@ryanml ryanml force-pushed the fix-6604 branch 3 times, most recently from eb00eef to d0aafb7 Compare November 6, 2019 22:00
fmarier pushed a commit to fmarier/brave-core that referenced this pull request Nov 6, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml added the CI/skip-android Do not run CI builds for Android label Nov 7, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 162805b into master Nov 7, 2019
@ryanml ryanml deleted the fix-6604 branch November 7, 2019 15:31
ryanml added a commit that referenced this pull request Nov 7, 2019
Updating empty wallet message for unsupported regions
ryanml added a commit that referenced this pull request Nov 7, 2019
Updating empty wallet message for unsupported regions
ryanml added a commit that referenced this pull request Nov 7, 2019
Updating empty wallet message for unsupported regions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "no tokens" messaging on BR panel for BAT Points regions
3 participants