Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards Extension: delay loading until enabled (uplift to 0.72.x) #3802

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Rewards Extension: delay loading until enabled (uplift to 0.72.x) #3802

merged 1 commit into from
Oct 29, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 28, 2019 •
edited by bsclifton
Loading

Uplift of #3698
Fixes brave/brave-browser#3436

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 28, 2019
@brave-builds brave-builds added this to the 0.72.x - Dev milestone Oct 28, 2019
@kjozwiak
Copy link
Member

Looks like this never ran correctly and timed out after ~6mins. Restarting.

bsclifton
bsclifton approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks great! ++

@bsclifton bsclifton merged commit c2cf440 into 0.72.x Oct 29, 2019
@bsclifton bsclifton deleted the pr3698_rewards-delay-extension_0.72.x branch October 29, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases