Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve context of string language #3739

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Conversation

bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Oct 17, 2019

Fixes: brave/brave-browser#6537

Old:
Verification is not necessary to earn rewards for creator contributions

New:
Verification is not necessary to contribute your rewards to creators

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Old: 
Verification is not necessary to earn rewards for creator contributions

New: 
Verification is not necessary to contribute your rewards to creators
@bradleyrichter
Copy link
Contributor Author

cc @ryanml

@ryanml ryanml self-requested a review October 18, 2019 00:23
@ryanml ryanml self-assigned this Oct 18, 2019
@ryanml ryanml added this to the 0.73.x - Nightly milestone Oct 18, 2019
@ryanml ryanml removed their assignment Oct 18, 2019
@NejcZdovc NejcZdovc merged commit ffe74f1 into brave:master Oct 18, 2019
ryanml pushed a commit that referenced this pull request Oct 23, 2019
Improve context of string language
ryanml pushed a commit that referenced this pull request Oct 23, 2019
Improve context of string language
ryanml pushed a commit that referenced this pull request Oct 28, 2019
Improve context of string language
ryanml pushed a commit that referenced this pull request Oct 28, 2019
Improve context of string language
ryanml pushed a commit that referenced this pull request Oct 28, 2019
Improve context of string language
ryanml pushed a commit that referenced this pull request Oct 28, 2019
Improve context of string language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve context of string (subhead) for BR Wallet Verification Dialog
3 participants